[tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account

[Alexander Turenko]

> @@ -594,6 +594,7 @@ log_syslog_init(struct log *log, const char *init_str)
>  	log->fd = log_syslog_connect(log);
>  	if (log->fd < 0) {
>  		/* syslog indent is freed in atexit(). */
> +		diag_log();

1. It is need to be properly commented: we need to log a diagnostics
here until stacked diagnostics will be implemented (#1148).

2. syslog_connect_unix() does not set a diag, diag_log() will lead to an
assertion fail.

3. I would mention this change in the commit message, because it is not
part of the problem with Mac OS you described in it.