[tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL

[n.pettik]

Thanks, the only dubious nit I can spot: should we
set initiateTTrans for DDL operations which consist
of one box operations? Like: create index, drop index,
create trigger, drop trigger, drop constraint etc
For instance, we don’t set it for TRUNCATE stmt.
The only two operations which require starting transactions
are CREATE TABLE and RENAME. Btw, when checking
results of RENAME I’d also check that operation (update of
‘CREATE TRIGGER …' string) performed on _trigger has
been committed/rollbacked.