[tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format

Cyrill Gorcunov gorcunov at gmail.com
Sat Jul 6 09:50:02 MSK 2019


On Sat, Jul 06, 2019 at 01:59:08AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/07/06 00:13]:
> 
> LGTM. @totktonada, please provide a more thorough review.
> 
> One question is what happens to the output on client reconnect.

Since it gonna be new session the settings will be reset. I thought
also that we might need to provide some box.cgf option for default
output mode?

> Perhaps we should cache it on the client as well (this is the same
> issue with console language).

Well, seems so, still it is a bit unclear for me where to keep this
cached value.

As to "default lua" for 2.x series we need to think how to tune
up our test engine to setup yaml mode for all tests, since currently
test results are in yaml and we definitely don't wanna update every
test exsiting.




More information about the Tarantool-patches mailing list