[tarantool-patches] Re: [PATCH 3/5] sql: use 'varbinary' as a name of type instead of 'blob'

n.pettik korablev at tarantool.org
Tue Jul 30 16:43:06 MSK 2019


>>> func.c   :540, :1185, :1254, :1753
>>> vdbeapi.c:283, :382,  :1061
>>> vdbemem.c:996, :1022
>>> vdbeaux.c:1192
>> 
>> All these usages are in form of:
>> "string or blob is too big”
>> 
>> I think that blob is a good name for entity of varbinary
>> type. Another possible names are “binary sequence”,
>> “binary data” or “binary string”. The latter variant is used
>> in the ANSI specification. Now I’ve changed to “binary string”,
>> but if you can suggest better name, let’s discuss it.
> 
> No, I don't mind any name. I saw, that in the commit message
> you said
> 
>    "Thus, let's fix all visible to user messages using 'varbinary'
>     name of type instead of 'blob'."
> 
> And I noticed, that there are still visible messages mentioning blob.
> You can keep blob, or rename, or anything.

I’m okay with "binary string” as well, so let’s keep it.






More information about the Tarantool-patches mailing list