[tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems.
Alexander Turenko
alexander.turenko at tarantool.org
Tue Jul 23 12:40:16 MSK 2019
> I addressed this issue in a patch to tarantool/libyaml. Please check it out.
> This patch remains intact.
Okay. I don't have objections, but one comment.
> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w")
> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99")
Maybe it worth to declare a loop variable outside a loop initialization
statement in libyaml (and update the upstream PR)? I mean that if all
libyaml code follow C89, then we maybe should do it too in our changes.
What do you think?
More information about the Tarantool-patches
mailing list