[tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding

[n.pettik]

> On 24 Jul 2019, at 20:10, Konstantin Osipov <kostja at tarantool.org> wrote:
> 
> * Nikita Pettik <korablev at tarantool.org> [19/07/24 19:59]:
>> It was decided that for all integer literals we would return "INTEGER"
>> type, not "UNSIGNED". Accidentally, after substitution of unsigned
>> binding value type was set to "UNSIGNED". Let's fix that and set
>> "INTEGER" type.
> 
> the patch is lgtm but I'm not sure it covers all cases.
> 
> I've seen a lot of unsigned inthe tests.

I see only one more unsigned appearance:

box.execute("SELECT CAST('123' AS UNSIGNED);")
---
- metadata:
  - name: CAST('123' AS UNSIGNED)
    type: unsigned
  rows:
  - [123]
…

But I guess in this case user would be less surprised
if one saw unsigned type than integer.

> -- 
> Konstantin Osipov, Moscow, Russia