[tarantool-patches] Re: [PATCH v2 1/3] txn: move stmt list/savepoint manipulation out of txn_stmt_new

Konstantin Osipov kostja at tarantool.org
Tue Jul 30 15:10:59 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/07/30 15:04]:
> txn_stmt_new is supposed to simply allocate an initialize a new txn_stmt
> struct. Adding the new statement to the txn's statement list and setting
> up a savepoint for rollback looks confusing. Move it to txn_begin_stmt.
> ---

lgtm


-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list