[tarantool-patches] Re: [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

On 29/01/2019 17:29, imeevma at tarantool.org wrote:
> Some macros in pragma.c and pragma.h are obsolete because the
> values they are checking are no longer used or their usage makes
> no sense. Let's remove them.
> ---
>   src/box/sql/CMakeLists.txt |  2 --
>   src/box/sql/parse.y        |  4 ++--
>   src/box/sql/pragma.c       |  4 ----
>   src/box/sql/pragma.h       | 31 ++-----------------------------
>   src/box/sql/select.c       | 22 +++++++++++-----------
>   src/box/sql/sqliteInt.h    | 18 +-----------------
>   src/box/sql/where.c        | 46 ++++++++++++++++++++--------------------------
>   src/box/sql/whereInt.h     |  4 ++--
>   8 files changed, 38 insertions(+), 93 deletions(-)
> 
> diff --git a/src/box/sql/CMakeLists.txt b/src/box/sql/CMakeLists.txt
> index 7f7b60e..68e2929 100644
> --- a/src/box/sql/CMakeLists.txt
> +++ b/src/box/sql/CMakeLists.txt
> @@ -1,7 +1,5 @@
>   if(CMAKE_BUILD_TYPE STREQUAL "Debug")
>     add_definitions(-DSQLITE_DEBUG=1)
> -  add_definitions(-DSQLITE_ENABLE_SELECTTRACE)

Still is used in src/box/sql/printf.c.

> -  add_definitions(-DSQLITE_ENABLE_WHERETRACE)
>   endif()
>