[tarantool-patches] Re: [PATCH v1 4/4] sql: make sql checks on server side

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/01/10 23:12]:
> +		if (sql_checks_run(space->sql_checks,
> +				   space->def->opts.checks_ast, space->def,
> +				   old_tuple_raw, new_tuple_raw) != 0) {
> +			diag_raise();

Do you have a module named sql_checks? I believe you don't, one
reason is that we don't use plural for module names. Then
your method name should be sql_run_checks. But since this name is
meaningless, why not use a straightforward and self-explanatory
name, for example sql_validate_check_constraints()?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov