[tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute
imeevma at tarantool.org
Thu Jan 24 10:31:00 MSK 2019
Hi! Thanks for comments. Also, I sent wrong branch to review,
sorry about that. Right branch is:
On 1/22/19 10:58 PM, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
> On 19/01/2019 16:20, imeevma at tarantool.org wrote:
>> The goal of this patch-set is to make functions from execute.c
>> the only way to execute SQL statements. This goal includes
>> similar output for executed SQL statements no matter how they
>> were executed: through net.box or through box.
>> This is the eighth version of patch-set. It is not complete. It
>> still has no last part, which is replacing box.sql.execute by
>> box.execute, because it will lead to massive test editing.
> It was not necessary to resend the whole patchset just for such
> minor comments. Strictly speaking, it was not necessary for some
> other older versions.
>> For now this patch-set blocked by #3832. Small temporary fix added
>> to temporary patch of patch-set.
>> General information of difference from previous version of
> If we nonetheless consider this mail thread as a new patchset,
> the text below does not describe the difference correctly. It is
> an old description.
> Besides, in each cover-letter of each version you should list
> differences between each pair of sequential versions, as I know.
>> - Added new commit that removes lua_error() from luaL_tofield().
>> - Added new and fixed old comments and descriptions.
>> - Fixed some bugs.
>> - Refactoring.
>> A bit about patches of the patch-set:
>> Patch 1 removes lua_error() from luaL_tofield().
>> Patch 2 moves map creation from xrow functions to
>> sql_response_dump(). It allows us to use sql_response_dump() as
>> method of port.
>> Patch 3 creates port_sql and two its methods: dump_msgpack() and
>> Patch 4 creates dump_lua() method for port_sql.
>> Patch 5 adds binding to new_execute().
>> Patch 6 is temporary patch. It was created to check that
>> new_execute() is able to pass through tests created for execute().
>> Mergen Imeev (6):
>> lua: remove exceptions from function luaL_tofield()
>> iproto: move map creation to sql_response_dump()
>> iproto: create port_sql
>> lua: create method dump_lua for port_sql
>> lua: parameter binding for new execute()
>> sql: check new box.sql.execute()
>> src/box/execute.c | 507
>> src/box/execute.h | 63 ++----
>> src/box/iproto.cc | 18 +-
>> src/box/lua/call.c | 9 +-
>> src/box/lua/schema.lua | 23 +++
>> src/box/lua/sql.c | 37 +++-
>> src/box/lua/tuple.c | 3 +-
>> src/box/port.h | 1 -
>> src/box/xrow.c | 8 +-
>> src/box/xrow.h | 9 +-
>> src/lua/msgpack.c | 12 +-
>> src/lua/utils.c | 97 +++++-----
>> src/lua/utils.h | 8 +-
>> 13 files changed, 589 insertions(+), 206 deletions(-)
More information about the Tarantool-patches