[tarantool-patches] Re: [PATCH 1/2] gc: do not abort garbage collection if failed to unlink snap file

Kirill Yukhin kyukhin at tarantool.org
Tue Jan 29 16:00:45 MSK 2019

Hello Vladimir,
On 25 Jan 17:34, Vladimir Davydov wrote:
> We build the checkpoint list from the list of memtx snap files. So to
> ensure that it is always possible to recover from any checkpoint present
> in box.info.gc() output, we abort garbage collection if we fail to
> unlink a snap file. This introduces extra complexity to the garbage
> collection code, which makes it difficult to make WAL file removal fully
> asynchronous.
> Actually, it looks like we are being way too overcautious here, because
> unlink() doesn't normally fail so an error while removing a snap file is
> highly unlikely to occur. Besides, even if it happens, it still won't be
> critical, because we never delete the last checkpoint, which is usually
> used for backups/recovery. So let's simplify the code by removing that
> check.
> Needed for #3938
> ---
> https://github.com/tarantool/tarantool/issues/3938
> https://github.com/tarantool/tarantool/commits/dv/gh-3938-async-wal-file-removal

I've committed the patchset into 2.1 branch.
Could you pls backport it to 1.10 as well?

Regards, Kirill Yukhin

More information about the Tarantool-patches mailing list