[tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/01/10 23:12]:
> +	/** Checks AST expressions list. */
> +	struct ExprList *checks_ast;

I don't understand the comment. Is it a list of syntax trees or a
syntax tree containing all checks? You can't use plural in an
adjective. This is a systematic error which I have been pointing
out before.

> --- a/src/box/sql.c
> +++ b/src/box/sql.c
> @@ -1048,7 +1048,7 @@ sql_encode_table_opts(struct region *region, struct Table *table,
>  	int checks_cnt = 0;
>  	struct ExprList_item *a;
>  	bool is_view = table->def->opts.is_view;
> -	struct ExprList *checks = table->def->opts.checks;
> +	struct ExprList *checks = table->def->opts.checks_ast;

It's good manners to consistently rename stack variables when
renaming the corresponding member.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov