[tarantool-patches] Re: [PATCH 5/6] sql: fix error message for improperly created index

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Jan 14 17:06:24 MSK 2019

Thanks for the patch! See 1 comment below.

On 09/01/2019 15:13, Nikita Pettik wrote:
> Table can be created without any indexes (for instance, from Lua-land).
> On the other hand, bytecode generated for CREATE INDEX statement
> attempts at finding entry in _index space with given space id.
> In case it is not found error "wrong space id" is raised. On the other
> hand, it is obvious that such message is appeared when table doesn't
> have any created indexes yet. Hence, lets fix this message to indicate
> that primary key should be created before any secondary indexes.
> Closes #3914

The test index1.test.lua fails. I guess, because you introduce
ADD CONSTRAINT PRIMARY KEY only in the next commit. Lets move this
part of the test into the latter.

More information about the Tarantool-patches mailing list