[tarantool-patches] Re: [PATCH v4 5/6] sql: 'PRAGMA' result in YAML format
imeevma at tarantool.org
Thu Jan 24 17:53:22 MSK 2019
Hi! Thank you for review. Changed commit-message.
On 1/20/19 3:19 AM, n.pettik wrote:
>> New version:
>> commit a3e6e457680e9aef5af78ca7a92f1572fcfbdef4
>> Author: Mergen Imeev <imeevma at gmail.com>
>> Date: Thu Dec 13 21:07:31 2018 +0300
>> sql: 'PRAGMA' result in YAML format
> Commit's subject would look better with verb.
> For instance:
> sql: get results of PRAGMA statement in YAML format
> Or sort of.
> The rest is OK in this patch-set, so LGTM.
Fixed. New commit-message:
Author: Mergen Imeev <imeevma at gmail.com>
Date: Thu Dec 13 21:07:31 2018 +0300
sql: get results of PRAGMA statement in YAML format
Currently box.sql.execute ('PRAGMA') returns nothing, but prints
list of pragmas and their statuses to stdout. Such strategy is
considered to be wrong since output of this command would be
unavailable for users who redirect stdout, use net box connection
etc. This patch makes the command to return result as the rest of
SQL commands. The result contains only FLAG-type pragmas and their
statuses in YAML format.
More information about the Tarantool-patches