[tarantool-patches] Re: [PATCH v7 1/6] lua: remove exceptions from function luaL_tofield()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Jan 17 16:15:31 MSK 2019



On 17/01/2019 14:38, Konstantin Osipov wrote:
> * imeevma at tarantool.org <imeevma at tarantool.org> [19/01/15 19:14]:
>> Before this commit, the luaL_tofield() function threw a Lua
>> diff --git a/src/lua/utils.c b/src/lua/utils.c
>> index 978fe61..9a9fd3a 100644
>> --- a/src/lua/utils.c
>> +++ b/src/lua/utils.c
>> @@ -37,6 +37,8 @@
>>   #include <diag.h>
>>   #include <fiber.h>
>>   
>> +#include "box/error.h"
> 
> Please don't. This violates encapsulation.
> 
> 

Oh, of course. Sorry, dismissed it. Mergen, we can not
use ClientError outside of box/ module. See exception.h for
available errors. I think, LuajitError is the most suitable
here.




More information about the Tarantool-patches mailing list