[tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield()
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue Jan 22 22:58:52 MSK 2019
Thanks for the fixes!
> Diff between versions:
>
> commit 07bcff72336fe861fd51d895fe088662a9d09fe4
> Author: Mergen Imeev <imeevma at gmail.com>
> Date: Thu Jan 17 15:00:27 2019 +0300
>
> Temporary: Review fixes
Please, do not merge diff of all comments into a single one. It
is hardly possible to restore which part of this diff corresponds
to which comment. Inline diff, fixing one comment, under this comment,
like Nikita does.
Also, I see that the branch still stores the old patchset. Please,
push it. Until that I can not review it.
> commit 3080ab1d7d2e8d8716ac91fc71150db7cde4ffe4
> Author: Mergen Imeev <imeevma at gmail.com>
> Date: Fri Jan 11 21:16:12 2019 +0300
>
> lua: remove exceptions from function luaL_tofield()
>
> Before this commit, the luaL_tofield() function threw a Lua
> exception when an error occurred. This behavior has been changed
> in this commit, now it sets diag_set() and returns -1 in case of
> an error.
>
> Needed for ...3505
Please, use #, not ... .
More information about the Tarantool-patches
mailing list