[tarantool-patches] Re: [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h

Imeev Mergen imeevma at tarantool.org
Thu Jan 24 17:52:17 MSK 2019


Hi! Thank you for review.

On 1/20/19 3:16 AM, n.pettik wrote:
>> commit 28ff08bf9df3a3948fdc399f4801f01d170c52a5
>> Author: Mergen Imeev <imeevma at gmail.com>
>> Date:   Wed Dec 12 21:58:54 2018 +0300
>>
>>     sql: remove unused macros from pragma.c and pragma.h
>>
>>     Some macros in pragma.c and pragma.h are obsolete because the
>>     values they are checking are no longer used. Let's remove them.
> In fact they are used, but their usage makes no sense.
> Then LGTM.

Fixed. New commit-message:

commit 1f667d56f6684a5cb7030097a66c4ac8b46d36cc
Author: Mergen Imeev <imeevma at gmail.com>
Date:   Wed Dec 12 21:58:54 2018 +0300

     sql: remove unused macros from pragma.c and pragma.h

     Some macros in pragma.c and pragma.h are obsolete because the
     values they are checking are no longer used or their usage makes
     no sense. Let's remove them.





More information about the Tarantool-patches mailing list