[tarantool-patches] Re: [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Wed Jan 30 16:59:14 MSK 2019
Please, do not send forthcoming fix of my comments as a new version. They
are too minor.
On 29/01/2019 17:29, imeevma at tarantool.org wrote:
> This patch-set defines the types for the result columns of EXPLAIN
> and PRAGMA commands. In addition, it fixes some problems of the
> PRAGMA commands that have something to do with their result.
>
> https://github.com/tarantool/tarantool/issues/3832
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3832-no-column-types
>
> Changes in fifth version:
> - Couple of commit-messages were fixed.
>
> v1:
> https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-set-column-types-for-EXPLAIN-and-PRAGMA
> v2:
> https://www.freelists.org/post/tarantool-patches/PATCH-v2-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA
> v3:
> https://www.freelists.org/post/tarantool-patches/PATCH-v3-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA
> v4:
> https://www.freelists.org/post/tarantool-patches/PATCH-v4-06-sql-set-column-types-for-EXPLAIN-and-PRAGMA
>
>
> Mergen Imeev (6):
> sql: remove unused macros from pragma.c and pragma.h
> sql: fix "PRAGMA parser_trace" result
> sql: Show currently set sql_default_engine
> sql: fix "PRAGMA case_sensitive_like" result
> sql: get results of PRAGMA statement in YAML format
> sql: set column types for EXPLAIN and PRAGMA
>
> src/box/execute.c | 5 +-
> src/box/sql/CMakeLists.txt | 2 -
> src/box/sql/parse.y | 4 +-
> src/box/sql/pragma.c | 195 ++++++++++----------------
> src/box/sql/pragma.h | 259 ++++++++++++++++++++++-------------
> src/box/sql/prepare.c | 52 +++++--
> src/box/sql/select.c | 22 +--
> src/box/sql/sqliteInt.h | 22 +--
> src/box/sql/where.c | 46 +++----
> src/box/sql/whereInt.h | 4 +-
> test/sql-tap/gh-2367-pragma.test.lua | 35 +++--
> test/sql/iproto.result | 69 ++++++++++
> test/sql/iproto.test.lua | 18 ++-
> test/sql/misc.result | 17 +++
> test/sql/misc.test.lua | 10 ++
> test/sql/sql-debug.result | 53 +++++++
> test/sql/sql-debug.test.lua | 19 +++
> test/sql/suite.ini | 2 +-
> 18 files changed, 530 insertions(+), 304 deletions(-)
> create mode 100644 test/sql/sql-debug.result
> create mode 100644 test/sql/sql-debug.test.lua
>
> --
> 2.7.4
>
More information about the Tarantool-patches
mailing list