[tarantool-patches] Re: [PATCH 00/12] vinyl: statistics improvements

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/01/15 17:20]:
> This patch set adds a few metrics necessary for implementing compaction
> randomization and transaction throttling, but it's useful on its own,
> because it makes box.stat.vinyl() a little bit more useful when it comes
> to performance analysis. Here's an example of box.stat.vinyl() output
> with this patch set applied:

Please write a documentation request which explains the meaning of
these variables. AFAIK these stats are still not described in the
manual. Please try to explain why these statistics are useful, and
how they can be used.

> ---
> - tx:
>     conflict: 0
>     commit: 1979052
>     rollback: 0
>     statements: 2
>     transactions: 1
>     gap_locks: 0
>     read_views: 0
>   regulator:

let's rename it to rate_limit or rate_limits? Regulator is not
specific enough. What does it regulate?

>     dump_bandwidth: 10485760
Without comments even I forget the meaning of these.

>     dump_watermark: 20023725
>     write_rate: 7085581

>   memory:
>     tuple_cache: 0
>     tx: 2388
>     level0: 19394239
>     page_index: 4422529
>     bloom_filter: 1517177

Good.

>   disk:
>     data_compacted: 500330587

What's this? 

>     data: 762493299
>     index: 41814873
>   scheduler:
>     dump_time: 186.61679973663

It's total dump time, the name can be confused with
last dump time.

>     tasks_inprogress: 3
>     dump_output: 2115930554
>     compaction_queue: 213022513
>     compaction_output: 4130054964
>     compaction_time: 737.99443827965
>     dump_count: 136
>     tasks_failed: 0
>     tasks_completed: 1839
>     dump_input: 2061676471
>     compaction_input: 5646476938

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov