[tarantool-patches] Re: [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Jan 30 16:56:58 MSK 2019



On 29/01/2019 17:29, imeevma at tarantool.org wrote:
> Currently PRAGMA case_sensitive_like returns nothing. This seems
> wrong, since other similar pragmas return their status. Fixed in
> the current patch.
> ---
>   src/box/sql/pragma.c    | 23 +++++++++--------------
>   src/box/sql/pragma.h    |  7 +++----
>   src/box/sql/sqliteInt.h |  2 ++
>   test/sql/misc.result    | 17 +++++++++++++++++
>   test/sql/misc.test.lua  | 10 ++++++++++
>   5 files changed, 41 insertions(+), 18 deletions(-)

Why the previous commit puts a pragma-related test into
gh-***-pragma.test.lua, but this puts into misc.test.lua?

Please, be consistent. Move this test into the same
file as the previous commit did.




More information about the Tarantool-patches mailing list