[tarantool-patches] Re: [PATCH v8 4/6] lua: create method dump_lua for port_sql

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jan 29 23:42:25 MSK 2019

Thanks for the patch! See 2 comments below.

> commit 78e3d54239d51ad52ebf377acb016c66426299ec
> Author: Mergen Imeev <imeevma at gmail.com>
> Date:   Fri Dec 21 16:48:37 2018 +0300
>      lua: create method dump_lua for port_sql
>      This patch creates the dump_lua method for port_sql. It also
>      defines a new function box.sql.new_execute(), which will be
>      converted to box.sql.execute().
>      Part of ...3505

1. Please, replace ... with # in all patches, as I asked in the
review of the first commit.

2. I think, that it is time to finally finish this patchset
and remove "new_execute" from this commit, and in the
last commit replace "sql.execute" with "execute".

More information about the Tarantool-patches mailing list