[tarantool-patches] Re: [PATCH] tuple: fix hashing of integer numbers

Kirill Yukhin kyukhin at tarantool.org
Tue Jan 29 16:33:14 MSK 2019


Hello Vladimir,
On 22 Jan 19:13, Vladimir Davydov wrote:
> Integer numbers stored in tuples as MP_FLOAT/MP_DOUBLE are hashed
> differently from integer numbers stored as MP_INT/MP_UINT. This breaks
> select() for memtx hash indexes and vinyl indexes (the latter use bloom
> filters). Fix this by converting MP_FLOAT/MP_DOUBLE to MP_INT/MP_UINT
> before hashing if the value can be stored as an integer. This is
> consistent with the behavior of tuple comparators, which treat MP_FLOAT
> and MP_INT as equal in case they represent the same number.
> 
> Closes #3907
> ---
> https://github.com/tarantool/tarantool/issues/3907
> https://github.com/tarantool/tarantool/commits/dv/gh-3907-fix-integer-number-hashing

I've checked your patch into 2.1 branch.

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list