[PATCH] vinyl: fix crash if iterator is used throughout DDL

Vladimir Davydov vdavydov.dev at gmail.com
Thu Feb 14 17:57:28 MSK 2019


On Thu, Feb 14, 2019 at 04:54:46PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/14 16:23]:
> > vy_run_iterator doesn't take a reference to the format it uses to decode
> > statements loaded from disk. As a result, the format may be deleted by
> > DDL, leading to a use-after-free bug. Fix this by taking a reference to
> > the format used by an iterator.
> 
> Please add a comment before _ref():
> 
> /* 
>  * Please remove this kludge when proper DDL locking is
>  * implemented on transaction management level or multi-version
>  * data dictionary is in place. 
>  */
> > 
> 
> With that, oK to push.

Pushed to 2.1 and 1.10.



More information about the Tarantool-patches mailing list