[tarantool-patches] Re: [PATCH] httpc: add checking of headers in httpc:request

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Feb 16 00:17:15 MSK 2019


Hi!

>>         5. Out of 80 symbols. 
>>
>> 2. Still out of 80.
> My text editor shows 70 symbols.
> 

Then there is something wrong with your editor, sorry.

https://github.com/tarantool/tarantool/blob/romanhabibov/gh-3679-httpc-request/src/lua/httpc.c#L180

Lets count. Here you have 6 tabs - 6 * 8 = 48 symbols. Then you have 55 symbols of

     "headers must be string or table with \"__tostring\"");

48 + 55 = 103.

Also, the error string is not aligned by opening parenthesis.

In your email I see, that you have 4 symbols tab, what gives you 79 symbols, but
tab width in this file should be 8. So probably you mistakenly set tab width to
4 and the editor shows you < 80 width. Please, fix.





More information about the Tarantool-patches mailing list