[tarantool-patches] [PATCH v2] lua/fiber: Fix abort on malformed join input
Vladimir Davydov
vdavydov.dev at gmail.com
Mon Feb 25 15:54:12 MSK 2019
On Sat, Feb 23, 2019 at 04:34:42PM +0300, Cyrill Gorcunov wrote:
> If I create a new fiber and the join to himself we get an abort:
>
> | tarantool> f = require('fiber')
> | ---
> | ...
> |
> | tarantool> f.join(f.self())
> | tarantool: src/fiber.c:407: fiber_join: Assertion `fiber->flags & FIBER_IS_JOINABLE' failed.
> | Aborted (core dumped)
>
> we should better throw an error.
Pushed to 2.1 and 1.10. Thanks!
>
> v2: by georgy@
> - add a testcase
We don't include changelog in the commit message. Please put it after
the diff separator (---) so that it is ignored by git-am.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
We don't sign-off patches :-)
> ---
> src/lua/fiber.c | 6 +++++-
> test/app/fiber.result | 11 +++++++++++
> test/app/fiber.test.lua | 7 +++++++
> 3 files changed, 23 insertions(+), 1 deletion(-)
More information about the Tarantool-patches
mailing list