[tarantool-patches] Re: [PATCH 06/12] vinyl: move vy_key_dup to generic code

Konstantin Osipov kostja at tarantool.org
Thu Feb 21 14:04:12 MSK 2019

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/21 13:31]:
> This helper function has nothing to do with vinyl - it's simply
> duplicates a msgpack array. Let's move it to tuple.c and rename
> it to key_dup.

Why to tuple.c and not in to msgpack? 

I don't like what this function is doing and how it's doing it, so
I'd rather bury it in vinyl or get rid of it, not make a generic

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list