[tarantool-patches] Re: [PATCH] sql: remove tests on ORDER BY/LIMIT + DELETE

[n.pettik]

> On 4 Feb 2019, at 18:34, Ivan Koptelov <ivan.koptelov at tarantool.org> wrote:
> 
> Removes obsolete tests on ORDER BY/LIMIT + DELETE. This
> functionality was not supported for some time, but a few tests
> were still existing.
> 
> Closes #2172
> ---
> Branch https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete
> Issue https://github.com/tarantool/tarantool/issues/2172
> 
> test/sql-tap/e_delete.test.lua | 188 -----------------------------------------
> 1 file changed, 188 deletions(-)
> 
> diff --git a/test/sql-tap/e_delete.test.lua b/test/sql-tap/e_delete.test.lua
> index 84a4e0a22..0a81eb3bd 100755
> --- a/test/sql-tap/e_delete.test.lua
> +++ b/test/sql-tap/e_delete.test.lua
> @@ -305,194 +305,6 @@ if (0 > 0) then
>          DELETE FROM t8 NOT INDEXED WHERE a=5;
>        END;]], {"NOT INDEXED"}},
>     })
> -    -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses (described
> -    -- below) are unsupported for DELETE statements within triggers.
> -    —

If I’m not mistaken, tests starting from e_delete-2.0 are disabled
(under if 0 > 0). So you can delete even more tests.

Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define:
I guess it is related to this patch. Seems that it is turned off, so I
assume we can delete it alongside with code under it.