[tarantool-patches] Re: [PATCH 3/9] vinyl: use uncompressed run size for range split/coalesce/compaction

Konstantin Osipov kostja at tarantool.org
Wed Feb 6 13:46:28 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/06 13:31]:
> Only because after the patch I don't need to use random() to generate
> data that would trigger compaction - compaction logic uses uncompressed
> sizes now so we can use string.rep(), which is faster.

It is faster but it may impact other properties of the runs - like
physical run size. For example you begin getting much more pages per
run, for all runs except the top-level one. 
I would avoid using string.rep() anywhere in vinyl test data,
unless I intentionally want to check the effects of inserting data
with high compression rate.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list