[tarantool-patches] Re: [PATCH 1/2] sql: add sqlite3 msgpack result function

[n.pettik]

> On 27 Jan 2019, at 03:28, Roman Khabibov <roman.habibov at tarantool.org> wrote:
> 
> Add function like sqlite3_result_blob that sets subtype of out parameter as
> SQL_SUBTYPE_MSGPACK. It allows to encode msg pack fields.
> 
> Needed for #3372
> ---
> src/box/sql/sqliteInt.h |  3 +++
> src/box/sql/vdbeapi.c   | 13 +++++++++++++
> 2 files changed, 16 insertions(+)
> 
> diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
> index 7e16edc9a..9b4db93d3 100644
> --- a/src/box/sql/sqliteInt.h
> +++ b/src/box/sql/sqliteInt.h
> @@ -465,6 +465,9 @@ sqlite3_value_numeric_type(sqlite3_value *);
> sqlite3 *
> sqlite3_context_db_handle(sqlite3_context *);
> 
> +void
> +sqlite3_result_msgpack(sqlite3_context *, const void *,
> +		    int, void (*)(void *));

Broken indentation; add named arguments.

> 
> void
> sqlite3_result_blob(sqlite3_context *, const void *,
> diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c
> index 9e57af051..ed7b67e3b 100644
> --- a/src/box/sql/vdbeapi.c
> +++ b/src/box/sql/vdbeapi.c
> @@ -360,6 +360,19 @@ invokeValueDestructor(const void *p,	/* Value to destroy */
> 	return SQLITE_TOOBIG;
> }
> 
> +void
> +sqlite3_result_msgpack(sqlite3_context * pCtx,
> +		    const void *z, int n, void (*xDel) (void *)
> +    )

The same is here. At least, fix names of params according to our codestyle.