[tarantool-patches] Re: [PATCH v1 1/4] box: introduce new helpers in column_mask.h

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/02/08 16:22]:
> Refactored column_mask.h definitions: introduced a new routine
> column_mask_is_overflowed, column_mask_is_set and macro
> COLUMN_MASK_BIT, COLUMN_MASK_SIZE.
> We need this helpers in further refactoring.
> 
> Needed for #3571
> ---
>  src/box/column_mask.h | 39 +++++++++++++++++++++++++++++++++------
>  1 file changed, 33 insertions(+), 6 deletions(-)
> 
> diff --git a/src/box/column_mask.h b/src/box/column_mask.h
> index d71911d46..6e9c0f81a 100644
> --- a/src/box/column_mask.h
> +++ b/src/box/column_mask.h
> @@ -50,7 +50,9 @@
>   * in such case we set not one bit, but a range of bits.
>   */
>  
> -#define COLUMN_MASK_FULL UINT64_MAX
> +#define COLUMN_MASK_FULL	UINT64_MAX
> +#define COLUMN_MASK_BIT(n)	(((uint64_t)1)<<(n))
> +#define COLUMN_MASK_SIZE	((int)(sizeof(uint64_t)*8))

Please use CHAR_BIT constant instead of 8.

The patch otherwise looks good to me.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov