[tarantool-patches] Re: [PATCH 0/3] Concatenation operator type fixes
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Fri Feb 22 18:54:40 MSK 2019
LGTM.
On 19/02/2019 11:28, Nikita Pettik wrote:
> This patch makes concatenation operator follow ANSI rules.
> For now, only operands of string-like types (TEXT or BLOB) are
> accepted. What is more, fixed resulting type of concatenation:
> if both operands are of BLOB type, then the resulting value is of
> BLOB value too.
>
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3544-fix-randomblob-type
> Issue: https://github.com/tarantool/tarantool/issues/3544
>
> Nikita Pettik (3):
> sql: fix value of mask to map VDBE memory type
> sql: allow only string-like arguments for concatenation
> sql: fix resulting type for concatenation operator
>
> src/box/errcode.h | 1 +
> src/box/sql/vdbe.c | 59 ++++++++++++++++++++++++++++++++++++++---
> src/box/sql/vdbeInt.h | 9 +++++++
> src/box/sql/vdbeapi.c | 2 +-
> test/box/misc.result | 1 +
> test/sql-tap/autoinc.test.lua | 12 ++++-----
> test/sql-tap/e_select1.test.lua | 4 +--
> test/sql-tap/func.test.lua | 4 +--
> test/sql-tap/sort.test.lua | 6 ++---
> test/sql-tap/tkt2192.test.lua | 4 +--
> test/sql-tap/trigger5.test.lua | 4 +--
> test/sql/types.result | 42 +++++++++++++++++++++++++++++
> test/sql/types.test.lua | 16 +++++++++++
> 13 files changed, 143 insertions(+), 21 deletions(-)
>
> --
> 2.15.1
>
>
More information about the Tarantool-patches
mailing list