[tarantool-patches] Re: [PATCH 1/3] salad: make heap struct more friendly to use

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Feb 22 21:38:50 MSK 2019



On 22/02/2019 21:26, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/02/22 14:39]:
>> Now heap API works with struct heap_node only, which forces a
>> user to constantly call container_of. Such a code looks really
>> awful. This commit makes heap taking and returning user defined
>> structures, and removes container_of clue.
>>
>> It is worth noting, that the similar API rb-tree and b-tree
>> have. Even rlist has its rlist_*_entry() wrappers, and mhash
>> provides macroses to define your own value type.
> 
> OK to push.
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 
Pushed to 2.1.



More information about the Tarantool-patches mailing list