[PATCH] vinyl: fix crash if iterator is used throughout DDL

Konstantin Osipov kostja at tarantool.org
Thu Feb 14 16:54:46 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/14 16:23]:
> vy_run_iterator doesn't take a reference to the format it uses to decode
> statements loaded from disk. As a result, the format may be deleted by
> DDL, leading to a use-after-free bug. Fix this by taking a reference to
> the format used by an iterator.

Please add a comment before _ref():

/* 
 * Please remove this kludge when proper DDL locking is
 * implemented on transaction management level or multi-version
 * data dictionary is in place. 
 */
> 

With that, oK to push.

 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list