[PATCH] test: fix app/socket sporadic failure

Vladimir Davydov vdavydov.dev at gmail.com
Thu Feb 28 18:31:53 MSK 2019


On Thu, Feb 28, 2019 at 06:09:41PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failure:
> 
>  | --- app/socket.result	Mon Feb 25 17:32:49 2019
>  | +++ app/socket.reject	Mon Feb 25 17:39:51 2019
>  | @@ -2827,7 +2827,7 @@
>  |  ...
>  |  echo_fiber ~= nil
>  |  ---
>  | -- true
>  | +- false
>  |  ...
>  |  client:write('hello')
>  |  ---
> 
> This happens, because we don't wait for echo_fiber to start.
> Use a channel to make sure it does. Also, increase read/write
> timeouts from 0.1 up to 5 seconds - it won't increase the test
> runtime, but it will make it more robust.
> 
> Closes #4022
> ---
> https://github.com/tarantool/tarantool/issues/4022
> https://github.com/tarantool/tarantool/commits/dv/test-fixes
> 
>  test/app/socket.result   | 12 +++++++++---
>  test/app/socket.test.lua |  9 ++++++---
>  2 files changed, 15 insertions(+), 6 deletions(-)

Pushed to 2.1 and 1.10.



More information about the Tarantool-patches mailing list