[PATCH v2 1/4] box: move memtx_tree implementation to source file

Vladimir Davydov vdavydov.dev at gmail.com
Thu Feb 21 16:26:54 MSK 2019


The subject line prefix should be 'memtx:' I think.

On Wed, Feb 13, 2019 at 12:32:25PM +0300, Kirill Shcherbatov wrote:
> Refactored memtx_tree code so that memtx_tree.h contained only
> the signature of the tree object constructor memtx_tree_index_new,
> while all implementation details were in memtx_tree.c.
> This will further allow to template the implementation details.
> 
> Needed for #3961
> ---
>  src/box/memtx_tree.c | 62 ++++++++++++++++++++++++++++++++++++++--
>  src/box/memtx_tree.h | 68 ++------------------------------------------
>  2 files changed, 63 insertions(+), 67 deletions(-)

The patch is good, but I think we shouldn't stop at memtx_tree and do
the same for other memtx indexes - hash, bitset, rtree. Please do it in
the scope of this patch.



More information about the Tarantool-patches mailing list