[tarantool-patches] Re: [PATCH] sql: remove tests on ORDER BY/LIMIT + DELETE

n.pettik korablev at tarantool.org
Mon Feb 11 22:00:57 MSK 2019

> On 11 Feb 2019, at 16:09, Konstantin Osipov <kostja at tarantool.org> wrote:
> * n.pettik <korablev at tarantool.org> [19/02/09 08:47]:
>>> Why ever delete tests? Why not let them (expectedly) fail?
>> Could you please clarify the purpose of such tests?
> In this particular case I don't entirely rule out the possibility
> of these features re-appearing in our product.

Are you kidding? It was you who supported idea of removing
this feature:

You can always use WHERE pk IN (subquery expr) - this is the standard alternative.
ORDER BY ... LIMIT is only useful if your optimizer is very weak, otherwise you can do it efficiently with a standard compliant SQL, in relational spirit.

But OK, even if we decided to enable this thing, it wouldn’t
be possible without implementing it from a scratch.
Almost all code related to ORDER BY + DELETE was
removed a long ago, only a few lines remained.
And even those lines haven’t been kept up to date
during numerous refactoring/reworking patches
(aka dead code). Hence, those tests are completely
useless and there is no chance that they will be turned on
again someday.

More information about the Tarantool-patches mailing list