[tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas
korablev at tarantool.org
Tue Feb 12 20:05:51 MSK 2019
When you send patch consisting from >= 2 commits,
you should organise it as patch-set with covering letter:
If there are multiple patches you want to submit in one go (e.g. this is a big feature which requires some preparatory patches to be committed first), you should send each patch in a separate email in reply to a cover letter. To format a patch series accordingly, pass the following options to git format-patch:
> On 12 Feb 2019, at 10:31, Stanislav Zudin <szudin at tarantool.org> wrote:
> The pragmas "query_only" and "read_uncommitted" didn't affect anything
> and were removed.
> Fixed an error in pragma index_list which caused a segmantation fault.
> pragma sql_default_engine accepts only strings.
> Thus pragma sql_default_engine('memtx') is a well-formed command,
> while pragma sql_default_engine(memtx) or
> pragma sql_default_engine("memtx") are considered as ill-formed and
> raise an error.
> Closes #3733
You twice close issue - in both commits.
Please, do it only in the last one.
The rest in this patch is OK.
More information about the Tarantool-patches