[tarantool-patches] Re: [PATCH] Emit NOPs in case of a replication conflict

Konstantin Osipov kostja at tarantool.org
Tue Feb 12 22:29:21 MSK 2019

* Georgy Kirichenko <georgy at tarantool.org> [19/02/12 18:09]:
>  				struct error *e = diag_last_error(diag_get());
>  				/**
> -				 * Silently skip ER_TUPLE_FOUND error if such
> -				 * option is set in config.
> +				 * In case of ER_TUPLE_FOUND error replca row
> +				 * with nop if such option is set in config.

Please fix the comment. replca -> replica, the English grammar is
not looking proper to me.

Let's write something along these lines:

In case of ER_TUPLE_FOUND error and replication_skip_conflict
configuration error, skip applying the foreign row and replace it
with NOP in the local write ahead log.

Otherwise the patch is OK to push.

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list