[tarantool-patches] Re: [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Feb 4 16:06:31 MSK 2019
Hi! Thanks for the fixes!
> diff --git a/src/box/sql/pragma.c b/src/box/sql/pragma.c
> index 5729fe6..476771d 100644
> --- a/src/box/sql/pragma.c
> +++ b/src/box/sql/pragma.c
> @@ -569,18 +566,6 @@ sqlite3Pragma(Parse * pParse, Token * pId, /* First part of [schema.]id field */
> }
> break;
> }
> -#ifndef NDEBUG
1. New question - why it was NDEBUG, but became SQLITE_DEBUG?
> - case PragTyp_PARSER_TRACE:{
> - if (zRight) {
> - if (sqlite3GetBoolean(zRight, 0)) {
> - sqlite3ParserTrace(stdout, "parser: ");
> - } else {
> - sqlite3ParserTrace(0, 0);
> - }
> - }
> - break;
> - }
> -#endif
>
> /*
> * Reinstall the LIKE and functions. The variant
> diff --git a/test/sql/sql-debug.test.lua b/test/sql/sql-debug.test.lua
> new file mode 100644
> index 0000000..721ef19
> --- /dev/null
> +++ b/test/sql/sql-debug.test.lua
2. Now the test does not touch engine, but it is still run twice
with two engines in test config.
More information about the Tarantool-patches
mailing list