[PATCH v1 2/4] box: rework memtx_tree class to be reusable

[Vladimir Davydov]

On Tue, Feb 05, 2019 at 02:58:37PM +0300, Kirill Shcherbatov wrote:
> The memtx tree class has been redesigned so that it can be used
> to store arbitrary structures in the future. This makes possible
> to implement type hints in memtx in subsequent patches.
> 
> Needed for #3961
> ---
>  src/box/memtx_tree.c      | 715 ++--------------------------
>  src/box/memtx_tree.h      |  68 +--
>  src/box/memtx_tree_impl.h | 960 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1008 insertions(+), 735 deletions(-)
>  create mode 100644 src/box/memtx_tree_impl.h

You move a huge chunk of code to another file and modify it at the same
time, which makes the patch impossible to review. Please split it in
two. First, do the necessary modifications in memtx_tree.c (it's OK to
include *.c files in C), then rename memtx_tree.c to memtx_tree_impl.h.