[tarantool-patches] Re: [PATCH 0/2] Compute derived collation for concatenation

[Kirill Yukhin]

Hello,

On 16 Jan 16:13, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3937-concatenation-collation
> Issue: https://github.com/tarantool/tarantool/issues/3937
> 
> According to ANSI concatenation operator should derive collation
> from its operands. This small patch-set implements this procedure
> according to rules described in SQL standard.
> 
> Nikita Pettik (2):
>   sql: refactor sql_expr_coll and sql_binary_compare_coll_seq functions
>   sql: compute resulting collation for concatenation
> 
>  src/box/sql/expr.c          | 125 +++++++++++++++++++++++++++++---------------
>  src/box/sql/select.c        |  27 ++++++----
>  src/box/sql/sqliteInt.h     |  14 +++--
>  src/box/sql/where.c         |  56 ++++++++++----------
>  src/box/sql/whereexpr.c     |  23 ++++----
>  test/sql/collation.result   | 102 ++++++++++++++++++++++++++++++++++++
>  test/sql/collation.test.lua |  46 ++++++++++++++++
>  7 files changed, 296 insertions(+), 97 deletions(-)

Your patches were pushed into 2.1 branch few days ago.

--
Regards, Kirill Yukhin