[tarantool-patches] Re: [PATCH v3 5/7] memtx: rework memtx_tree to store arbitrary nodes
Kirill Shcherbatov
kshcherbatov at tarantool.org
Tue Feb 26 15:10:10 MSK 2019
> This looks like encapsulation violation. Please either use
> MEMTX_TREE_ELEM_SET for this or introduce MEMTX_TREE_ELEM_CLEAR
> helper.
If we use MEMTX_TREE_ELEM_SET for this purpose, in case of hints we need this
additional check
- (elem_ptr)->hint = tuple_hint(info, key_def); \
+ (elem_ptr)->hint = info != NULL ? tuple_hint(info, key_def) : 0; \
So, let's introduce MEMTX_TREE_ELEM_CLEAR.
> How is this going to work for multikey indexes?
You may show kshch/gh-1257-multikey-index branch - there is a multikey indexes
prototype over patches that we are discuss.
More information about the Tarantool-patches
mailing list