[PATCH v3 2/4] vinyl: remove extra quota check from vy_quota_use

Konstantin Osipov kostja at tarantool.org
Tue Feb 12 21:15:16 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/12 20:28]:
> Before waking up a fiber that is waiting for quota, we always first
> check if it can actually consume it, see vy_quota_signal. Hence the
> extra check in vy_quota_use is needed only to prevent spurious wakeups.
> It doesn't seem to be wise to add such a check to a hot path as a
> counter-mesaure to such an unlikely scenario. Let's remove it - after
> all it isn't critical if a spuriously woken up fiber exceeds the limit.

OK to push.



-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list