[Tarantool-patches] [PATCH v6 2/4] popen: Introduce a backend engine

Cyrill Gorcunov gorcunov at gmail.com
Thu Dec 26 10:19:21 MSK 2019


On Thu, Dec 26, 2019 at 10:14:41AM +0300, Konstantin Osipov wrote:
...
> > +	say_debug("popen: %d: read idx [%s:%d] buf %p count %zu "
> > +		  "fds %d timeout %.9g",
> > +		  handle->pid, stdX_str(idx), idx, buf, count,
> > +		  handle->fds[idx], timeout);
> > +
> > +	return coio_read_fd_timeout(handle->fds[idx],
> > +				    buf, count, timeout);
> > +}
> 
> Right, so could you please use struct coio here, and not
> coio_read_fd_timeout? I.e. convert handle->fds to coio?

I'll try. Thanks Kostya!


More information about the Tarantool-patches mailing list