[Tarantool-patches] [PATCH v4] test: fix flaky socket test

[Alexander Turenko]

> [017] --- app/socket.result	Wed Dec 25 01:18:29 2019
> [017] +++ app/socket.reject	Wed Dec 25 01:19:30 2019
> [017] @@ -40,7 +40,7 @@
> [017]  ...
> [017]  test_run:cmd("push filter '(error: .builtin/.*[.]lua):[0-9]+' to '\\1'")
> [017]  ---
> [017] -- true
> [017] +- Hello, world
> 
> It seems we connected to some of our socket server rather then test-run.
> Looks like the same ipv4 / ipv6 problem.
> 
> After the following patch for test-run I don't see it anymore (don't
> sure I made enough runs, however):
> 
> diff --git a/lib/test_suite.py b/lib/test_suite.py
> index 84b99f4..0a137c3 100644
> --- a/lib/test_suite.py
> +++ b/lib/test_suite.py
> @@ -197,7 +197,7 @@ class TestSuite:
>      def start_server(self, server):
>          # create inspector daemon for cluster tests
>          inspector = TarantoolInspector(
> -            'localhost', server.inspector_port
> +            '127.0.0.1', server.inspector_port
>          )
>          inspector.start()
>          # fixme: remove this string if we fix all legacy tests
> diff --git a/test_run.lua b/test_run.lua
> index e37b559..fc1b833 100644
> --- a/test_run.lua
> +++ b/test_run.lua
> @@ -458,7 +458,7 @@ local inspector_methods = {
>  local function inspector_new(host, port)
>      local inspector = {}
>  
> -    inspector.host = host or 'localhost'
> +    inspector.host = host or '127.0.0.1'
>      inspector.port = port or tonumber(os.getenv('INSPECTOR'))
>      if inspector.port == nil then
>          error('Inspector not started')

Patch: https://github.com/tarantool/test-run/pull/197

WBR, Alexander Turenko.