[Tarantool-patches] [PATCH] box/console: Handle multireturn in lua mode
Cyrill Gorcunov
gorcunov at gmail.com
Wed Dec 25 16:11:28 MSK 2019
On Wed, Dec 25, 2019 at 03:36:07PM +0300, Alexander Turenko wrote:
> Looks good in general and works correct even with nils at the end.
>
> We however should add a test case for this, otherwise sooner or later
> we'll unable to make changes w/o fear to broke something. I propose to
> add a case with nils at the end as well as simple 1, 2, 3 multireturn.
>
> I put several nits below. Some of them are pointed by our [Lua Style
> Guide][1], another ones are what I see across other parts of our
> codebase. My intention here is to keep the style more or less consistent
> and so make it more comfortable to work with the code (hope not only for
> me, otherwise it is not productive).
>
> [1]: https://www.tarantool.io/en/doc/1.10/dev_guide/lua_style_guide/
Thanks! I'll update and resend together with a testcase.
More information about the Tarantool-patches
mailing list