[Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE

[Nikita Pettik]

On 24 Dec 17:26, Vladislav Shpilevoy wrote:
> Thanks for the review!
> 
> On 24/12/2019 02:23, Nikita Pettik wrote:
> > On 18 Dec 14:00, Chris Sosnin wrote:
> >>  create mode 100644 test/sql/autoincrement.result
> >>  create mode 100644 test/sql/autoincrement.test.lua
> >>
> >> diff --git a/test/sql/autoincrement.test.lua b/test/sql/autoincrement.test.lua
> > 
> > Patch itself is LGTM (as obvious). But I am not a big fan of placing each
> > test in separate file (at least when there's no specific issue for that).
> 
> As you know, me neither. I added this new file to put here all
> autoincrement stuff now and in future. We have sql-tap/autoinc,
> but sql-tap tests are really hard to write and fix.

It's hard in comparison with sql/ suite. But in general, sql tap tests
are quite simple and easy to write (IMHO).
 
> > Moreover, in commit message it is said that this patch is follow-up to
> > #4546, so could you move this test to gh-4546-sql-drop-grants.test.lua ?
> 
> 4546 was about table grants. The test in autoincrement file about a
> different bug - drop of sequence. It is kinda related to 4546 in that
> sequence grants also should be dropped, if their sequence is deleted.

Ok, then I will simply remove 'follow-up' remark and push it to master.