[Tarantool-patches] [PATCH v2 2/3] box: make constraint operations transactional
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Sun Dec 22 17:59:52 MSK 2019
Hi! Thanks for the review!
On 21/12/2019 21:54, Sergey Ostanevich wrote:
> Hi!
>
> Im looking to the latest branch romanhabibov/gh-3503-constr-names_v3,
> apparently with changes from Vlad?
>
> Although the change is simple, it is not relevant to the patchset?
The change is relevant, because allows to simplify CreateConstraintID
object creation.
>
> @@ -1408,14 +1419,14 @@ ModifyIndex::~ModifyIndex()
> /** CreateIndex - add a new index to the space. */
> class CreateIndex: public AlterSpaceOp
> {
> -public:
> - CreateIndex(struct alter_space *alter)
> - :AlterSpaceOp(alter), new_index(NULL), new_index_def(NULL)
> - {}
> /** New index. */
> struct index *new_index;
> /** New index index_def. */
> struct index_def *new_index_def;
> +public:
> + CreateIndex(struct alter_space *alter, struct index_def *def)
> + :AlterSpaceOp(alter), new_index(NULL), new_index_def(def)
> + {}
> virtual void alter_def(struct alter_space *alter);
> virtual void prepare(struct alter_space *alter);
> virtual void commit(struct alter_space *alter, int64_t lsn);
>
> And I'm still not sure about memory allocation/deallocation is correct during
> constraint id creation/drop.
If you've found an error, then please, share. I fixed all the
problems I found.
>
> Regards,
> Sergos
>
More information about the Tarantool-patches
mailing list