[Tarantool-patches] [PATCH v6 1/4] coio: Export helpers and provide coio_read_fd_timeout
Konstantin Osipov
kostja.osipov at gmail.com
Fri Dec 20 10:48:47 MSK 2019
* Cyrill Gorcunov <gorcunov at gmail.com> [19/12/17 15:57]:
> There is no reason to hide functions. In particular
> we will use coio_write_fd_timeout and coio_read_fd_timeout
> for popen.
AFAIU the only difference between the new function and
coio_read_timeout() is that the new function works without
struct coio* object, but uses coio_wait(), which creates/
destroys this object on demand.
Could you provide a rationale for this? coio_wait has to call
EPOLL_CTL_ADD/EPOLL_CTL_DEL on every wait, so it tripples the
number of syscalls per wait.
On the other hand I realize that it's not super important
for popen IO, but still I don't understand *why* you need this.
--
Konstantin Osipov, Moscow, Russia
More information about the Tarantool-patches
mailing list