[Tarantool-patches] [tarantool-patches] [PATCH v2 2/2] say: take getaddrinfo() errors into account

[Alexander Turenko]

Only one comment.

unit/coio fails on FreeBSD:

[006] Test failed! Result content mismatch:
[006] --- unit/coio.result	Wed Dec 11 09:58:11 2019
[006] +++ unit/coio.reject	Wed Sep 18 08:51:42 2019
[006] @@ -1,3 +1,6 @@
[006] +#   Failed test 'getaddrinfo error message'
[006] +#   in /home/vagrant/tarantool/test/unit/coio.cc at line 100
[006] +# Looks like you failed 1 test of 3 run.
[006]  	*** stat_timeout_test ***
[006]  	*** stat_timeout_test: done ***
[006]  	*** stat_notify_test ***
[006] @@ -10,5 +13,5 @@
[006]  1..3
[006]  ok 1 - getaddrinfo
[006]  ok 2 - getaddrinfo retval
[006] -ok 3 - getaddrinfo error message
[006] +not ok 3 - getaddrinfo error message
[006]  	*** test_getaddrinfo: done ***

https://gitlab.com/tarantool/tarantool/-/jobs/375844818

Please, also push a branch with -full-ci postfix: this will run the
whole testing matrix on the branch in GitLab-CI. It worth to verify this
just in case.

WBR, Alexander Turenko.

On Tue, Dec 10, 2019 at 07:25:05PM +0300, Roman Khabibov wrote:
> Hi! Thanks for the review.